Skip to content

(fix)Boards: Adafruit_Camera_ESP32-S3-Pin fixes #9021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 20, 2023
Merged

(fix)Boards: Adafruit_Camera_ESP32-S3-Pin fixes #9021

merged 7 commits into from
Dec 20, 2023

Conversation

ladyada
Copy link
Contributor

@ladyada ladyada commented Dec 18, 2023 •
edited
Loading

Release hardware has changed some pinouts!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2023 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Update esp32-hal-tinyusb.c":
    • summary looks empty
    • type/action looks empty
  • the commit message "more pins":
    • summary looks empty
    • type/action looks empty
  • the commit message "re-fix pinout that was reverted":
    • summary looks empty
    • type/action looks empty
  • the commit message "update pins":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).
⚠️ Please consider squashing your 7 commits (simplifying branch history).
⚠️ The Pull Request description looks very brief, please check if more details can be added.

👋 Hello ladyada, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 2650c84

@caternuson caternuson mentioned this pull request Dec 18, 2023
Closed
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards labels Dec 19, 2023
@VojtechBartoska
Copy link
Contributor

@ladyada Please update PR name to more specific one. Thanks!

@VojtechBartoska VojtechBartoska added the Resolution: Awaiting response Waiting for response of author label Dec 20, 2023
@VojtechBartoska VojtechBartoska added this to the 3.0.0-RC1 milestone Dec 20, 2023
@me-no-dev me-no-dev merged commit 9d0274b into espressif:master Dec 20, 2023
@VojtechBartoska VojtechBartoska changed the title Pin fixes for the Camera board (fix)Boards: Adafruit_Camera_ESP32-S3-Pin fixes Dec 20, 2023
@VojtechBartoska VojtechBartoska removed the Resolution: Awaiting response Waiting for response of author label Dec 20, 2023
@ladyada
Copy link
Contributor Author

ladyada commented Dec 20, 2023

apologies will be better on next time - i was so tired 😓
its for this cool new hardware!

https://www.adafruit.com/product/5420

@VojtechBartoska
Copy link
Contributor

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Milestone
3.0.0-RC1
Development

Successfully merging this pull request may close these issues.
5 participants
@ladyada @VojtechBartoska @P-R-O-C-H-Y @me-no-dev @hathach